fix: comment typo 'mas' -> 'mask' in two TODOs - #3372
Merged
ptrendx merged 1 commit intoAug 19, 2026
Merged
Conversation
github-actions
Bot
added
the
community-contribution
Contributor
Greptile SummaryCorrects “mas” to “mask” in two TODO comments in the JAX fused-attention tests.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (6): Last reviewed commit: "fix: comment typo 'mas' -> 'mask' in two..." | Re-trigger Greptile |
cyanguwa
previously approved these changes
Aug 13, 2026
Collaborator
|
If the DCO is fixed, I can merge this one quickly without running CI, because it's only changes to the comments. Thanks. |
ptrendx
previously approved these changes
Aug 13, 2026
Member
|
In order to fix DCO you need to sign your commits. See https://github.com/NVIDIA/TransformerEngine/blob/main/CONTRIBUTING.rst#sign-your-work |
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
andrewwhitecdw
force-pushed
the
codequality/test-fused-attn-comment-typo-mas-mask-in-two-todos
branch
2 times, most recently
from
August 19, 2026 14:53
9323f26 to
6aeb71e
Compare
Contributor
Author
ptrendx
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a comment typo in
tests/jax/test_fused_attn.pywhere "mas" should be "mask" in two TODO lines.Changes
tests/jax/test_fused_attn.py: correctbias, mas andtobias, mask andin two TODO comments.Tests
Contributor guidelines